Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Using Include and referencing a navigation property will not result in repeated joins #6206

Closed
maumar opened this issue Jul 29, 2016 · 3 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@maumar
Copy link
Contributor

maumar commented Jul 29, 2016

When we apply Include and also access navigation property on the entity that was included, we generate JOINs for to the same table twice. We could potentially be smart about it and only do it once.

e.g.

ctx.As.Include(a => a.B).Where(a => a.B.Name == "Foo")
@divega
Copy link
Contributor

divega commented Aug 8, 2016

@maumar @anpete I see we have some possible overlap or duplication between this bug, #4900, #3816 and #3419.

Could you please figure out if we can consolidate into a smaller set of orthogonal bugs without loosing information?

@smitpatel
Copy link
Contributor

@maumar - Can you do a quick check if this is fixed after new include compiler ?

@maumar maumar modified the milestones: 2.0.0-preview1, Backlog Apr 28, 2017
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Apr 28, 2017
@maumar
Copy link
Contributor Author

maumar commented Apr 28, 2017

Yes, that is indeed fixed, closing

@ajcvickers ajcvickers changed the title Query :: repeated joins between Includes and nav props Query: Using Include and referencing a navigation property can result in repeated joins May 9, 2017
@ajcvickers ajcvickers changed the title Query: Using Include and referencing a navigation property can result in repeated joins Query: Using Include and referencing a navigation property will not result in repeated joins May 9, 2017
@ajcvickers ajcvickers modified the milestones: 2.0.0-preview1, 2.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

4 participants