Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commands: Only look for ConfigureServices on Startup #5677

Closed
bricelam opened this issue Jun 7, 2016 · 0 comments
Closed

Commands: Only look for ConfigureServices on Startup #5677

bricelam opened this issue Jun 7, 2016 · 0 comments
Assignees
@bricelam
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
1.1.0

Comments

@bricelam
Copy link
Contributor

bricelam commented Jun 7, 2016

This didn't explicitly come up during our conversation about #4546, but I feel like it was implied. We should keep Startup and ConfigureServices strictly an ASP.NET thing and push everyone else to use IDbContextFactory. This means we should revert the changes done for #3802.

When we do this, we should also ensure #5617 is done.
@bricelam bricelam self-assigned this Jun 7, 2016
@bricelam bricelam mentioned this issue Jun 7, 2016
Closed
@divega divega added this to the 1.0.1 milestone Jun 7, 2016
@bricelam bricelam added the tools label Sep 8, 2016
@bricelam bricelam removed the tools label Sep 29, 2016
@bricelam bricelam mentioned this issue Oct 6, 2016
Merged
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 6, 2016
@ajcvickers ajcvickers modified the milestones: 1.1.0-preview1, 1.1.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@bricelam @divega @ajcvickers