Skip to content
This repository was archived by the owner on Dec 8, 2018. It is now read-only.

DeveloperExceptionPage throws when SourceFileContent is null in an ICompilationException #344

Closed
rynowak opened this issue Jan 27, 2017 · 1 comment
Closed

DeveloperExceptionPage throws when SourceFileContent is null in an ICompilationException #344

rynowak opened this issue Jan 27, 2017 · 1 comment
Assignees
@kichalla
Labels
3 - Done bug
Milestone
2.0.0-preview1

Comments

@rynowak
Copy link
Member

rynowak commented Jan 27, 2017

I hit this case while working through some Razor issues.

The SourceFileContent is dereferenced here: https://github.com/aspnet/Diagnostics/blob/dev/src/Microsoft.AspNetCore.Diagnostics/DeveloperExceptionPage/DeveloperExceptionPageMiddleware.cs#L138

We should probably harden this code since it's an error page.
@Eilon Eilon added this to the 2.0.0-preview1 milestone Mar 4, 2017
@kichalla
Copy link
Member

ee1cfdf

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kichalla kichalla

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
3 participants
@Eilon @rynowak @kichalla