Skip to content
This repository was archived by the owner on Dec 8, 2018. It is now read-only.

DataStoreErrorLogger behaves differently under .NETStandard1.3 vs .NET 4.5.1 #342

Closed
Tratcher opened this issue Jan 9, 2017 · 1 comment
Closed

DataStoreErrorLogger behaves differently under .NETStandard1.3 vs .NET 4.5.1 #342

Tratcher opened this issue Jan 9, 2017 · 1 comment
Assignees
@ryanbrandenburg
Labels
3 - Done bug
Milestone
2.0.0-preview1

Comments

@Tratcher
Copy link
Member

Tratcher commented Jan 9, 2017 •
edited
Loading

Has the same issue with AsyncLocal value as HttpContextAccessor as referenced in bug aspnet/HttpAbstractions#723, it needs to be static.
@Tratcher Tratcher added the bug label Jan 9, 2017
@Eilon
Copy link
Member

Eilon commented Mar 4, 2017

So this: https://github.com/aspnet/Diagnostics/blob/dev/src/Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore/DataStoreErrorLogger.cs#L21

Needs to be static, just like https://github.com/aspnet/HttpAbstractions/pull/753/files#diff-ea251ec60f873af282ab3518b9f69124R33 ?

@Eilon Eilon added the 1 - Ready label Mar 4, 2017
@Eilon Eilon added this to the 2.0.0 milestone Mar 4, 2017
@ryanbrandenburg ryanbrandenburg mentioned this issue Apr 21, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryanbrandenburg ryanbrandenburg

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
3 participants
@Eilon @Tratcher @ryanbrandenburg