Consider showing LoaderExceptions when caught exception is ReflectionTypeLoadException

[pranavkm]

Based on discussion at aspnet/Mvc#4892 (comment). It would be nice to type load exceptions so that it's easier to figure out what went wrong rather than see a generic message that tells you to read LoaderExceptions

[pranavkm]

cc @Eilon \ @rynowak \ @halter73 \ @davidfowl

[pranavkm]

Are there other exception types that would benefit from a similar treatment? AggregateExceptions for instance?

[pranavkm]

Also @ajaybhargavb who's assigned this work :)

[halter73]

If you wanted to be super generic you could think about some reflection based logging. Maybe JSON serialization. I haven't tried it out to see how it would look for ReflectionTypeLoadExceptions and AggregateExceptions, but it might be worth looking into.

[pranavkm]

Not sure I follow @halter73 - is this essentially serializing the exception to the log?

[halter73]

Since this issue is filed in the diagnostics repo, I thought it would be about how to display exceptions in the error pages, not how it's logged. But yes, I'm essentially suggesting serializing the exception if it can be done in a way that's not too verbose/distracting. Maybe it can be put in a collapsible section like the result of Exception.ToString() is today.

I still think that MVC should catch ReflectionTypeLoadExceptions when it accesses Assembly.DefinedTypes and log it specially with LoaderExceptions like I suggest in aspnet/Mvc#4892 (comment).

[Eilon]

@ajaybhargavb this is part of what we discussed earlier. Would be nice to special case some exception types and show more detailed information about them.