Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

KeyVault Provider can Deadlock #664

Closed
dfaivre-pcs opened this issue May 17, 2017 · 0 comments
Closed

KeyVault Provider can Deadlock #664

dfaivre-pcs opened this issue May 17, 2017 · 0 comments
Assignees
@HaoK
Labels
3 - Done bug
Milestone
2.0.0

Comments

@dfaivre-pcs
Copy link

https://github.com/aspnet/Configuration/blob/dev/src/Microsoft.Extensions.Configuration.AzureKeyVault/AzureKeyVaultConfigurationProvider.cs#L44

AzureKeyVaultConfigurationProvider.Load does not configure it's GetAwaiter() continueOnCapturedContext option to false. Calling this from not async code bases can cause a deadlock.

Any chance we can use this instead?

LoadAsync().ConfigureAwait(false).GetAwaiter().GetResult()
@HaoK HaoK self-assigned this Jun 6, 2017
@HaoK HaoK added this to the 2.0.0 milestone Jun 6, 2017
@HaoK HaoK mentioned this issue Jun 12, 2017
Merged
@HaoK HaoK closed this as completed in #676 Jun 14, 2017
@HaoK HaoK added 3 - Done and removed 2 - Working labels Jun 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HaoK HaoK

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@HaoK @dfaivre-pcs