Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringSegment bounds checking calculation can overflow #172

Closed
JunTaoLuo opened this issue Nov 22, 2016 · 1 comment
Closed

StringSegment bounds checking calculation can overflow #172

JunTaoLuo opened this issue Nov 22, 2016 · 1 comment
Assignees
@JunTaoLuo
Milestone
2.0.0-preview1

Comments

@JunTaoLuo
Copy link

The calculation here https://github.com/aspnet/Common/blob/dev/src/Microsoft.Extensions.Primitives/StringSegment.cs#L50 can overflow to a negative value if both offset and length are big enough.
@JunTaoLuo JunTaoLuo added this to the 1.2.0 milestone Nov 22, 2016
@JunTaoLuo JunTaoLuo self-assigned this Nov 22, 2016
@JunTaoLuo JunTaoLuo mentioned this issue Nov 22, 2016
Merged
@pranavkm
Copy link

Do you want to do a quick scan across repos and see if this crops up elsewhere? I see a at least one place in Mvc which has the same issue:

@pranavkm pranavkm mentioned this issue Nov 22, 2016
Closed
natemcmaster pushed a commit that referenced this issue Nov 16, 2018
@benaadams @rynowak
Don't capture asynclocals on timers (#172)
59f0806 
* Don't capture in timer delegate

* Don'y capture Asynclocals onto the TImer

* Don't allocate for cleanup delegate

* Don't capture asynclocals to Cleanup timer
@ghost ghost locked as resolved and limited conversation to collaborators Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
None yet
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
2 participants
@pranavkm @JunTaoLuo