Skip to content
This repository was archived by the owner on Nov 20, 2018. It is now read-only.

Verify that AI lightup logger filter rules is composed correctly with appsettings.json #64

Closed
pakrym opened this issue Jun 26, 2017 · 12 comments
Assignees
Milestone

Comments

@pakrym
Copy link
Contributor

pakrym commented Jun 26, 2017

Required layering:

  1. AI defaults
  2. AI setting.json file
  3. appconfig.json
@pakrym pakrym self-assigned this Jun 26, 2017
@glennc glennc added this to the 2.0.0 milestone Jun 26, 2017
@muratg
Copy link

muratg commented Jul 5, 2017

@pakrym status?

@pakrym
Copy link
Contributor Author

pakrym commented Jul 5, 2017

#69 is part of it, we also need to get a build of AI that has microsoft/ApplicationInsights-aspnetcore#486 in

@muratg muratg added bug and removed task labels Jul 7, 2017
@muratg
Copy link

muratg commented Jul 7, 2017

@pakrym will this be in today, or Monday?

cc @Eilon

@pakrym
Copy link
Contributor Author

pakrym commented Jul 7, 2017

@DamianEdwards said next week

@pakrym
Copy link
Contributor Author

pakrym commented Jul 7, 2017

Manual verification/validation part. All PR's are in but we still need to ingest AI package as soon as they produce it.

@muratg
Copy link

muratg commented Jul 7, 2017

@Eilon This will happen Monday possibly. cc @mikeharder as we'll need to ingest their packages.

cc @glennc to follow-up with AI folks as both @Eilon and me will be OOF.

@Eilon
Copy link
Member

Eilon commented Jul 18, 2017

@pakrym @glennc @mikeharder - What's left here?

@pakrym
Copy link
Contributor Author

pakrym commented Jul 18, 2017

@Eilon I was waiting for build of CLI with new AI package and out fixes to do verification on clean machine.

@Eilon
Copy link
Member

Eilon commented Jul 19, 2017

@pakrym ok - do we know when we'll have that? I would have thought that the AI in the CLI would be done by now, no?

@pakrym
Copy link
Contributor Author

pakrym commented Jul 19, 2017

@Eilon We have AI in VS light up bug now

@pakrym
Copy link
Contributor Author

pakrym commented Jul 19, 2017

@Eilon we can close this and do it as part of verification. I just want to make sure things work E2E without hacks.

@Eilon
Copy link
Member

Eilon commented Jul 19, 2017

@pakrym ok then please do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants