Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix build broken with giflib workaround #179

Closed
diniamo opened this issue Aug 16, 2024 · 8 comments
Closed

Nix build broken with giflib workaround #179

diniamo opened this issue Aug 16, 2024 · 8 comments

Comments

@diniamo
Copy link
Contributor

diniamo commented Aug 16, 2024

6a6678a broke the Nix build, of course, a revert patch is possible, but not preferred. Any idea why?

meson.build:57:9: ERROR: C shared or static library 'gif' not found
@artemsen
Copy link
Owner

Sorry, I am rather a Linux-guy than FreeBSD one =)
This was done by advice from FreeBSD maintainer.
I tried to revert this fix and build fails, so it works at least for FreeeBSD 14.1.

@diniamo
Copy link
Contributor Author

diniamo commented Aug 17, 2024

Would it be possible to check with pkgconfig first, and use the workaround as a fallback?

@artemsen
Copy link
Owner

The problem is that giflib doesn't support pkg-config.

@diniamo
Copy link
Contributor Author

diniamo commented Aug 17, 2024

How? It used to work before the commit, which only fixed the FreeBSD build.

@artemsen
Copy link
Owner

Perhaps it depends on giflib path. Or may be it because of this bug.
GitHub CI and freshports.org say this fix is ​​fine.
Sorry, I don't know how to make it work in FreeBSD without this patch. Do you have any ideas?

@diniamo
Copy link
Contributor Author

diniamo commented Aug 17, 2024

Nothing other than what I've already suggested: using the workaround as a fallback.

@diniamo
Copy link
Contributor Author

diniamo commented Aug 17, 2024

That seems to have done it, thanks! Would it be possible to make a release with this soon? The nixpkgs version is pretty outdated.

@artemsen
Copy link
Owner

I need to fix a couple of bugs. We'll be released by the end of summer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants