Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not drop netstandard2.0 #148

Closed
DorianGreen opened this issue Sep 25, 2023 · 1 comment
Closed

Do not drop netstandard2.0 #148

DorianGreen opened this issue Sep 25, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@DorianGreen
Copy link

I noticed that some PRs: #142, #128 made changes to framework versions.
I'd like to add my 2 cents on framework support.

I do agree that Ardalis.Result.AspnetCore should require net8 support once it comes out, but there shouldn't be many issues supporting both net6 and net8, as those are both LTS and not everyone will be able to upgrade right away.

In Adralis.Result and Ardalis.Result.FluentValidation there is no dependency on net6+ at all, and the packages can target netstandard2.0 exclusively. If there are modern language features that are in use then you can add a net6+ target.

There are many projects that are still using .net framework and will take many years to migrate. don't alienate your users by excluding their frameworks, or forcing them to stay on older package versions because they cant update.

As for centralizing versions in Directory.Build.Props, you can provide a default there, and override it in individual projects. You can also use a naming convention and use a element to assign correct versions - anything containing AspnetCore should only have net6+ versions, others should have netstandard2.0

I am happy to create a PR to fix these issues

@ardalis
Copy link
Owner

ardalis commented Sep 29, 2023

I'm open to your PR to keep netstandard support. Thanks.

@ardalis ardalis added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants