Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Request headers when using fingerprint generator or header generator are not saved in context.request.headers #1055

Open
Pijukatel opened this issue Mar 6, 2025 · 1 comment
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@Pijukatel
Copy link
Contributor

Pijukatel commented Mar 6, 2025

Request headers are correctly present when making the request, but context is not aware of them.
This is due to the fact that the request headers are set directly on Playwright in browserforge and this bypasses our common header setting approach

Make sure that regardless of how the headers are set, they are present in the context.request.headers

This is same situation as when setting headers through header generator - also missing in the context.

@Pijukatel Pijukatel added bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team. labels Mar 6, 2025
@Pijukatel Pijukatel changed the title bug: Request headers when using fingerprint generator are not saved in context.request.headers bug: Request headers when using fingerprint generator or header generator are not saved in context.request.headers Mar 7, 2025
@Pijukatel
Copy link
Contributor Author

Either we do some internal refactoring to make it available or we wait for Playwright support.

Feature is tagged with 1.52 microsoft/playwright#16239 (upcoming release)

We have to wait for such functionality to make it to the Python release as well, but maybe that would give as option how to handled this on Playwright level in straight forward way. Jeust get the headers from Playwright and save them to context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

No branches or pull requests

1 participant