Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(venn): 初始化韦恩图 #2831

Merged
merged 26 commits into from
Sep 9, 2021
Merged

feat(venn): 初始化韦恩图 #2831

merged 26 commits into from
Sep 9, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Sep 2, 2021 •
edited by Angelii
Loading

PR includes

  • 交界处的填充色（需要专业的知识，去了解颜色的叠加 -> 目前是直接按照色板按顺序取色）
  • 图表组件：tooltip 展示（部分没有触发、tooltip 展示内容 -> 默认可读）、label 展示
  • 容器大小：计算 padding
  • 文档、Demo
  • 单测

参考内容

Screenshot

Before After
❌ image
image

@visiky visiky changed the title feat(venn): 初始化韦恩图 wip: feat(venn): 初始化韦恩图 Sep 2, 2021
@pr-triage pr-triage bot removed the PR: unreviewed label Sep 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2021 •
edited
Loading

🎊 PR Preview 5dfac49 has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2831.surge.sh?type=diff&date=2021-09-09

🕐 Build time: 148.148s

🤖 By surge-preview

@visiky visiky force-pushed the plot-venn branch 3 times, most recently from f600f23 to 2e191d3 Compare September 3, 2021 06:50
visiky
visiky commented Sep 3, 2021
View reviewed changes
@visiky visiky force-pushed the plot-venn branch 2 times, most recently from 26b8176 to 4922a89 Compare September 4, 2021 06:16
visiky added 14 commits September 4, 2021 14:37
@coveralls
Copy link

coveralls commented Sep 4, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1216096602

  • 215 of 217 (99.08%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 95.612%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/plots/venn/types.ts 0 1 0.0%
src/utils/color/blend.ts 49 50 98.0%
Totals Coverage Status
Change from base Build 1186255225: -0.01%
Covered Lines: 6724
Relevant Lines: 6846
💛 - Coveralls

hustcc
hustcc reviewed Sep 6, 2021
View reviewed changes
@visiky visiky changed the title wip: feat(venn): 初始化韦恩图 feat(venn): 初始化韦恩图 Sep 6, 2021
@visiky
Copy link
Member Author

visiky commented Sep 6, 2021

移除了 chroma-js，包大小减少了 20+kb

visiky and others added 4 commits September 6, 2021 18:56
@visiky
test(utils): 补充单测
88a539d
@Angelii
test: venn图的基础配置的单测和文档 (#2836)
17e5b06 
* test: venn图的基础配置的单测和文档

* refactor: 处理lint警告，删除暂无用变量

* test: 补充和修改单测的写法

Co-authored-by: 酥云 <[email protected]>
@Angelii
refactor(padding): venn图增加padding配置项 (#2838)
5dfac49 
* refactor(padding): venn图增加padding配置项

* refactor(padding): 把resolveAllPadding方法抽成公共utils，重新处理venn的padding

* refactor(padding): 去掉多余的normalPadding方法

Co-authored-by: 酥云 <[email protected]>
@Angelii
refactor(blend): 优化颜色叠加计算 (#2837)
2f6d422 
* refactor(blend): 优化颜色叠加计算

* test(blend): 补充blend的单测

* refactor: 调整打包限制的大小

* refactor(blend): 删除nameToHex工具,使用color-utils

Co-authored-by: 酥云 <[email protected]>
@visiky visiky merged commit e2b84c6 into master Sep 9, 2021
@visiky visiky deleted the plot-venn branch September 9, 2021 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@visiky @coveralls @hustcc @Angelii