Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export default-options, you can use staticMethod to getDefaultOptions, like Plot.getDefaultOptions() #2307

Merged
merged 3 commits into from
Feb 5, 2021
Merged

feat: export default-options, you can use staticMethod to getDefaultOptions, like Plot.getDefaultOptions() #2307

merged 3 commits into from
Feb 5, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Feb 4, 2021 •
edited
Loading

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

feat(static-default-options): 获取默认配置项设置为静态方法

  • line,column,bar,area,tiny-line/column/area,ring-progress,progress （主要供 multi-view 使用）

Screenshot

Before After
❌ ✅

@visiky
feat(static-default-options): 获取默认配置项设置为静态方法
bf42d97 
- [x] line,column,bar,area,tiny-line/column/area,ring-progress,progress （主要供 multi-view 使用）
@visiky visiky requested a review from hustcc February 4, 2021 14:01
@visiky visiky changed the title feat: export default-options, you can getDefaultOptions by static-property' feat: export default-options, you can getDefaultOptions by static-method Feb 4, 2021
@visiky visiky changed the title feat: export default-options, you can getDefaultOptions by static-method feat: export default-options, you can getDefaultOptions by staticMethod Feb 4, 2021
@visiky visiky changed the title feat: export default-options, you can getDefaultOptions by staticMethod feat: export default-options, you can use staticMethod to getDefaultOptions, like Plot.getDefaultOptions() Feb 4, 2021
@visiky visiky requested a review from lxfu1 February 4, 2021 14:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 537460012

  • 102 of 102 (100.0%) changed or added relevant lines in 23 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 96.582%
Files with Coverage Reduction New Missed Lines %
src/utils/transform/word-cloud.ts 1 97.75%
Totals Coverage Status
Change from base Build 533511665: -0.002%
Covered Lines: 4882
Relevant Lines: 4935
💛 - Coveralls

@hustcc hustcc merged commit 8efbdd6 into master Feb 5, 2021
@hustcc hustcc deleted the default-options branch February 5, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@lxfu1 lxfu1 Awaiting requested review from lxfu1

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @hustcc