Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: multiview 支持 multi-plots && 支持 association 🎉🎉🎉 #2294

Merged
merged 13 commits into from
Feb 24, 2021
Merged

feat: multiview 支持 multi-plots && 支持 association 🎉🎉🎉 #2294

merged 13 commits into from
Feb 24, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Feb 2, 2021 •
edited
Loading

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After
❌
❌
❌

@visiky visiky added the WIP label Feb 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2021 •
edited
Loading

😭 Deploy PR Preview f6677a7 failed. Build logs

🤖 By surge-preview

@visiky visiky force-pushed the multiview-association branch from 0682b05 to 7d5f498 Compare February 2, 2021 13:54
hustcc
hustcc reviewed Feb 2, 2021
View reviewed changes
@visiky visiky changed the title feat: multiview 支持 multi-plots && 支持 association 🎉🎉🎉 wip: feat: multiview 支持 multi-plots && 支持 association 🎉🎉🎉 Feb 3, 2021
@pr-triage pr-triage bot removed the PR: unreviewed label Feb 3, 2021
@visiky visiky force-pushed the multiview-association branch 3 times, most recently from b2765bb to 3b9a1a4 Compare February 7, 2021 05:55
@coveralls
Copy link

coveralls commented Feb 7, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 580247592

  • 154 of 154 (100.0%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 96.706%
Totals Coverage Status
Change from base Build 580110991: 0.1%
Covered Lines: 5080
Relevant Lines: 5130
💛 - Coveralls

@visiky visiky force-pushed the multiview-association branch from 3b9a1a4 to 4c06c6c Compare February 14, 2021 09:23
@visiky visiky changed the title wip: feat: multiview 支持 multi-plots && 支持 association 🎉🎉🎉 feat: multiview 支持 multi-plots && 支持 association 🎉🎉🎉 Feb 14, 2021
@visiky visiky force-pushed the multiview-association branch from 206ea6d to 8ec044e Compare February 14, 2021 15:22
@visiky visiky removed the WIP label Feb 14, 2021
@visiky visiky force-pushed the multiview-association branch 6 times, most recently from 35d7319 to c0c6795 Compare February 16, 2021 03:55
@visiky visiky force-pushed the multiview-association branch from c0c6795 to 5552d83 Compare February 19, 2021 02:30
@hustcc hustcc merged commit 90a8592 into master Feb 24, 2021
@hustcc hustcc deleted the multiview-association branch February 24, 2021 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visiky @coveralls @hustcc