Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复 chord 单测和增加 pie 单测 #2127

Merged
merged 2 commits into from
Dec 21, 2020
Merged

修复 chord 单测和增加 pie 单测 #2127

merged 2 commits into from
Dec 21, 2020

Conversation

visiky
Copy link
Member

@visiky visiky commented Dec 19, 2020 •
edited
Loading

  • test: 修复 chord 测试挂了
  • test: 增加单测，保证"开启中心文本交互时，显式注册 tooltip 交互可以开启 tooltip"

PR includes

Screenshot

Before After
解读：在某些场景下，环图开启中心文本交互时，需要开启开启 tooltip；这里可以通过显示声明 tooltip 交互即可

@visiky visiky requested review from hustcc and lessmost December 19, 2020 06:04
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2020 •
edited
Loading

😭 Deploy PR Preview 8a3ec80 failed. Build logs

🤖 By surge-preview

@hustcc hustcc merged commit 5a8c85d into master Dec 21, 2020
@hustcc hustcc deleted the fix-2096 branch December 21, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc approved these changes

@lessmost lessmost Awaiting requested review from lessmost

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

环图开启中心文本交互之后，无法开启 tooltip
2 participants
@visiky @hustcc