Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(geometry): 修改 geometry/base 中存在多个相同的时候,导致索引出错 #1575

Merged
merged 1 commit into from
Sep 15, 2020
Merged

fix(geometry): 修改 geometry/base 中存在多个相同的时候,导致索引出错 #1575

merged 1 commit into from
Sep 15, 2020

Conversation

hustcc
Copy link
Member

@hustcc hustcc commented Sep 15, 2020

  • 一个图中存在多个相同的 geometry 的时候，在 geometry adaptor 使用 findGeometry 导致出错的问题

@auto-add-label auto-add-label bot added the Bug Something isn't working label Sep 15, 2020
@hustcc hustcc requested review from arcsin1 and visiky September 15, 2020 03:27
@arcsin1
Copy link
Contributor

arcsin1 commented Sep 15, 2020

在上游实例过程中 geometry 还没创建好吧 比如我在图表内 interval(params) 才开始创建好geometry

@hustcc
Copy link
Member Author

hustcc commented Sep 15, 2020

interval

外面使用的 interval 是包含有 interval + otherAdaptor 的。

@hustcc hustcc force-pushed the refactor-add-params-ext branch from c81152f to 53136fe Compare September 15, 2020 07:41
@hustcc hustcc requested a review from arcsin1 September 15, 2020 08:33
@arcsin1 arcsin1 merged commit d0884b0 into master Sep 15, 2020
@arcsin1 arcsin1 deleted the refactor-add-params-ext branch September 15, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcsin1 arcsin1 arcsin1 approved these changes

@visiky visiky Awaiting requested review from visiky

Assignees
No one assigned
Labels
Bug Something isn't working PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hustcc @arcsin1