Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(word-cloud): add willReadFrequently option when canvas getContext #3438

Merged
merged 1 commit into from
Jan 6, 2023
Merged

perf(word-cloud): add willReadFrequently option when canvas getContext #3438

merged 1 commit into from
Jan 6, 2023

Conversation

ArcherGu
Copy link
Contributor

使用词云图时，若更新数据或者更改图表的尺寸会触发浏览器警告:

Canvas2D: Multiple readback operations using getImageData are faster with the willReadFrequently attribute set to true. See: <URL>

在 canvas.getContext 时，增加这个配置可以避免这个警告，优化部分性能。

ArcherGu added a commit to ArcherGu/archergu.me that referenced this pull request Dec 30, 2022
@ArcherGu
perf: word-cloud add willReadFrequently option when canvas getContext
7e1efd4 
see: antvis/G2Plot#3438
@visiky visiky merged commit ab1175b into antvis:master Jan 6, 2023
@ArcherGu ArcherGu deleted the perf-word-cloud-will-read-frequently-warning branch January 7, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky visiky approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArcherGu @visiky