Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bar): 条形图重构,不需要反转数据 调整下坐标系即可 #2914

Merged
merged 5 commits into from
Nov 27, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Oct 12, 2021

PR includes

Screenshot

Before After
image
image image

|

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2021

🎊 PR Preview b11a17a has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2914.surge.sh?type=diff&date=2021-11-04

🕐 Build time: 132.989s

🤖 By surge-preview

@visiky visiky requested a review from hustcc October 13, 2021 13:28
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1341316754

  • 24 of 24 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 95.633%

Files with Coverage Reduction New Missed Lines %
src/plots/box/adaptor.ts 2 94.74%
Totals Coverage Status
Change from base Build 1327649246: -0.004%
Covered Lines: 6843
Relevant Lines: 6965

💛 - Coveralls

@visiky visiky marked this pull request as draft October 14, 2021 12:44
@visiky
Copy link
Member Author

visiky commented Oct 14, 2021

breaking change 的改造,先不发布

@visiky visiky marked this pull request as ready for review November 4, 2021 03:05
@visiky visiky merged commit b1d8f47 into master Nov 27, 2021
@visiky visiky deleted the fix-bar-plot branch November 27, 2021 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

> 条形图缩略轴slider文案被反转了
3 participants