-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Remove timestamp from header to make script builds reproducible #672
Comments
if I am not wrong we added a way to customize the header in the script but I don't remember right now. |
It was discussed in #344 but right now it looks to me like header generation is hardcoded: Lines 199 to 203 in d3ceda3
|
i wouldn't change the current header, but rather add an option to use a custom template for the header. probably add some more variables that could be used. im pretty sure that's been discussed before and honestly shouldn't be very hard to implement |
I think that:
Can be the best option, if that variable is not set use the default one. In this way we can improve it without adding too many parameters in the code and the user can do whatevery he wants. I think too that isn't very difficult to implement. |
I want to add also #635 so we can do both in a single PR |
Is your feature request related to a problem? Please describe.
Currently, as a default, Amber adds a comment that looks like this to the top of a compiled file:
The outstanding issue here is the date entry, which specifies when the script has been built, down to the second. Fundamentally, this breaks reproducible builds -- i.e. the guarantee that you will get the exact same output given the exact same input.
Describe the solution you'd like
To aid in reproducibility efforts ongoing on several Linux distributions, it would be nice to have an option to disable adding a timestamp to built scripts.
This could be an environment variable, such as
AMBER_NO_TIMESTAMP
.Describe alternatives you've considered
Wrapping the compiler in a program that simulates a zero timestamp would be too cumbersome, and introduce fragility into an otherwise simple build process.
Post-processing the script to remove the date field would be even more fragile.
The text was updated successfully, but these errors were encountered: