Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if row is present when setting aria label of popup element #5750

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

babalaui
Copy link
Contributor

Issue #, if available:

Description of changes:

  • added check if rowData of popup row is not null. in some scenarios when no popup item was selected when opening the popup, the rowData was null, resulting in a crash when setting the aria label of the popup element.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

@babalaui babalaui requested a review from marinsokol5 February 20, 2025 13:53
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (a27e1e8) to head (1fa0673).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5750   +/-   ##
=======================================
  Coverage   87.08%   87.08%           
=======================================
  Files         598      598           
  Lines       43802    43803    +1     
  Branches     7171     7172    +1     
=======================================
+ Hits        38144    38145    +1     
  Misses       5658     5658           
Flag Coverage Δ
unittests 87.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babalaui babalaui merged commit ff16482 into master Feb 20, 2025
3 checks passed
@babalaui babalaui deleted the fix_popup_alabel branch February 20, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants