Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set score completion item when skipfilter true #5749

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

akoreman
Copy link
Contributor

Issue #, if available: NA

Description of changes: When we set skipFilter for a completion item to true, the filtering logic skips the part where $score is set which results in the score property of the item being ignored, resulting in unexpected ordering of items.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.08%. Comparing base (fbe3ddc) to head (0a0df17).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5749   +/-   ##
=======================================
  Coverage   87.08%   87.08%           
=======================================
  Files         598      598           
  Lines       43801    43802    +1     
  Branches     7171     7171           
=======================================
+ Hits        38143    38144    +1     
  Misses       5658     5658           
Flag Coverage Δ
unittests 87.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman merged commit a27e1e8 into ajaxorg:master Feb 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants