Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scroll cursor line to top editor for long inline preview #5514

Merged
merged 6 commits into from
Mar 20, 2024

Conversation

akoreman
Copy link
Contributor

Issue #, if available: NA

Description of changes: Currently, the scrolling of the editor to get the cursor at the top for long inline suggestions is not always working as intended:

Screen.Recording.2024-03-19.at.22.06.19.mov

This changes it to be more reliable:

Screen.Recording.2024-03-19.at.21.58.19.mov

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.56%. Comparing base (099011b) to head (3e13c31).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5514   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files         588      588           
  Lines       42535    42539    +4     
  Branches     7068     7068           
=======================================
+ Hits        36820    36826    +6     
+ Misses       5715     5713    -2     
Flag Coverage Δ
unittests 86.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoreman akoreman merged commit 529473b into ajaxorg:master Mar 20, 2024
3 checks passed
@akoreman akoreman deleted the inline_scroll_fix branch March 20, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants