feat: Allow not showing inline preview for completers when inlineEnabled is set to true.
#5315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5315 +/- ##
==========================================
+ Coverage 87.33% 87.39% +0.05%
==========================================
Files 574 574
Lines 45482 45534 +52
Branches 6934 6935 +1
==========================================
+ Hits 39723 39793 +70
+ Misses 5759 5741 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
akoreman
changed the title
inlineEnabled is set to true.inlineEnabled is set to true.
marinsokol5
approved these changes
Sep 19, 2023
akoreman
changed the title
inlineEnabled is set to true.inlineEnabled is set to true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: NA
Description of changes: Now, we have a property at the
AutoCompletelevel to enable inline preview for all completion items within thatAutoComplete. For some use-cases, users might want to have more granularity and only show inline previews for some of the registered completers.This adds a property to
Completerto allow hiding that completer from the inline preview.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.