-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotation level information to gutter tooltip #5101
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5101 +/- ##
==========================================
+ Coverage 86.62% 86.78% +0.15%
==========================================
Files 555 556 +1
Lines 42996 43097 +101
Branches 6709 6714 +5
==========================================
+ Hits 37247 37400 +153
+ Misses 5749 5697 -52
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and good to merge, but one thing that we should address in a follow-up pr, is that we should try to remove all the uses of innerHTML and use the safer buildDom
method. This would help to remove lang.escapeHTML from setAnnotations for instance and keep annotation objects instead of breaking them into arrays of text and type.
Currently, the gutter tooltip only shows the annotation text without any indication whether the messages are of the level 'error', 'warning' or 'info'. See image for current state of the gutter tooltip:
This change improves this by adding a header to the gutter tooltip indicating the total number of annotations per level for that row and an icon in front of each message indicating the annotation level for that annotation. Image of the gutter tooltip after this change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.