Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluation on the VIP and JHMDB datasets #10

Open
AndyTang15 opened this issue Jan 3, 2021 · 8 comments
Open

evaluation on the VIP and JHMDB datasets #10

AndyTang15 opened this issue Jan 3, 2021 · 8 comments

Comments

@AndyTang15
Copy link

AndyTang15 commented Jan 3, 2021

Hi Allan,

Happy new year! And many thanks for releasing the code of this great work!

I used the codebase and the pretrained model provided in the repo to evaluate the VIP and JHMDB datasets, the results are:
VIP: 37.12(mIOU), JHMDB: 57.62([email protected]) and 79.59([email protected]).

They are noticeably lower than the results in your paper:
VIP: 38.6(mIOU), JHMDB: 59.3([email protected]) and 84.9([email protected]).

Could you please help to check whether I evaluated them in a right way?
For VIP, I used the command:
python test.py --filelist eval/VIP_vallist.txt --model-type scratch --resume ../pretrained.pth --save-path vip_results --topk 10 --videoLen 4 --radius 12 --temperature 0.05 --cropSize 560

For JHMDB, I used the command:
python test.py --filelist eval/jhmdb_vallist.txt --model-type scratch --resume ../pretrained.pth --save-path jhmdb_results --topk 10 --videoLen 7 --radius 12 --temperature 0.05 --cropSize 320

The hyperparameters above were selected based on your paper except temperature (I've also tried 0.07 but found 0.05 is better).

BTW, there're two bugs for JHMDB evaluation:

  1. https://github.com/ajabri/videowalk/blob/master/code/data/jhmdb.py#L231
    the "sio" should be imported in this python file

  2. https://github.com/ajabri/videowalk/blob/master/code/test.py#L161
    it should be "test_utils" rather than "utils"

@ajabri
Copy link
Owner

ajabri commented Jan 21, 2021

Hi @AndyTang15,

Thanks for your interest, and I apologize for the late reply.

I haven't re-run the JHMDB and VIP evaluations since refactoring and retraining models for the code release, so thanks for bringing this to my attention, and I will take a closer look!

One detail that will improve the JHMDB result is that the radius should be (commensurately) decreased, since the input is about 4x smaller (320x320 v.s. 900x480). So, you might consider a radius of 5 instead of 12. I apologize for the confusion (and the typo in the appendix).

python test.py --filelist eval/jhmdb_vallist.txt --model-type scratch \
--resume ../pretrained.pth --save-path jhmdb_results \
--topk 10 --videoLen 7 --radius 5 --temperature 0.05 --cropSize 320

@AndyTang15
Copy link
Author

@ajabri Hi Allan,
Many thanks for your reply and help. I've tried radius=5 following your command, as well as radius=3. The results on JHMDB are:

radius=5: [email protected] 58.64, [email protected] 80.54
radius=3: [email protected] 58.84, [email protected] 80.23

The performances have all been improved but still lower than the results reported in your paper before refactoring, especially on [email protected], would it be possible for you to help me with this again? Many thanks!

@dmckee5
Copy link

dmckee5 commented Mar 4, 2021

Hi @ajabri and @AndyTang15,
Just wanted to check on whether you were able to reconcile the performance with results in the paper? I ran into the same issue with JHMDB performance, and I was not able to reproduce results with various radius settings.

Thanks!

@ajabri
Copy link
Owner

ajabri commented Mar 9, 2021

Hi @dmckee5,

I have not yet reconciled this issue (the lower [email protected] with this repository). If you are reporting or comparing to our results, at this point, please go ahead and report the result you've reproduced. I am hoping to get to this soon.

@pansanity666
Copy link

Hi @ajabri @AndyTang15 ,
May I ask where did you download the VIP dataset? The official link in the original paper is expired. Is there any cloud drive version?

@pansanity666
Copy link

Hi Allan,

Happy new year! And many thanks for releasing the code of this great work!

I used the codebase and the pretrained model provided in the repo to evaluate the VIP and JHMDB datasets, the results are: VIP: 37.12(mIOU), JHMDB: 57.62([email protected]) and 79.59([email protected]).

They are noticeably lower than the results in your paper: VIP: 38.6(mIOU), JHMDB: 59.3([email protected]) and 84.9([email protected]).

Could you please help to check whether I evaluated them in a right way? For VIP, I used the command: python test.py --filelist eval/VIP_vallist.txt --model-type scratch --resume ../pretrained.pth --save-path vip_results --topk 10 --videoLen 4 --radius 12 --temperature 0.05 --cropSize 560

For JHMDB, I used the command: python test.py --filelist eval/jhmdb_vallist.txt --model-type scratch --resume ../pretrained.pth --save-path jhmdb_results --topk 10 --videoLen 7 --radius 12 --temperature 0.05 --cropSize 320

The hyperparameters above were selected based on your paper except temperature (I've also tried 0.07 but found 0.05 is better).

BTW, there're two bugs for JHMDB evaluation:

  1. https://github.com/ajabri/videowalk/blob/master/code/data/jhmdb.py#L231
    the "sio" should be imported in this python file
  2. https://github.com/ajabri/videowalk/blob/master/code/test.py#L161
    it should be "test_utils" rather than "utils"

How did you get VIP_vallist.txt and jhmdb_vallist.txt ?

@Tsingularity
Copy link

Hi @AndyTang15, I used the same commands as you but looks like my results are much worse than urs. Just wondering is there other modification you have made to the code? Plus, what's the filelist you are using? The filelist I used is from the original UVC repo and it contains 268 lines. Any help would be appreciated. Thanks!

@rvandeghen
Copy link

Hi,
Where can I find your VIP_vallist.txt ? Also Did you use the VIP_Fine from this repo
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants