Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git should not be required in the master CMakeLists.txt #17

Closed
abdes opened this issue Aug 23, 2022 · 0 comments
Closed

Git should not be required in the master CMakeLists.txt #17

abdes opened this issue Aug 23, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@abdes
Copy link
Owner

abdes commented Aug 23, 2022

Currently it is required when updating the project's git revision hash. However, the GetGitRevisionDescription module already looks for Git and falls back as needed.

# ------------------------------------------------------------------------------
# Project description and (meta) information
# ------------------------------------------------------------------------------

# Get git revision
find_package(Git REQUIRED)
include(GetGitRevisionDescription)

The find_package(Git REQUIRED) should just be removed.

@abdes abdes added the bug Something isn't working label Aug 23, 2022
@abdes abdes self-assigned this Aug 23, 2022
@abdes abdes closed this as completed in 2c76104 Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant