Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getaddressbalance RPC method for block explorer usage #8452

Open
Tracked by #8435
mpguerra opened this issue Apr 24, 2024 · 1 comment · May be fixed by #9295
Open
Tracked by #8435

Update getaddressbalance RPC method for block explorer usage #8452

mpguerra opened this issue Apr 24, 2024 · 1 comment · May be fixed by #9295
Assignees
Labels
A-state Area: State / database changes

Comments

@mpguerra
Copy link
Contributor

mpguerra commented Apr 24, 2024

Motivation

In order to ensure that zebra is ready to act as a zcashd replacement, we need to implement the RPC methods required to support block explorers.

We currently support lightwalletd usage of the getaddressbalance RPC, however:

  1. zcashd accepts a single string parameter as well as an array of strings as an argument. Zebra only accepts an array of strings because lightwalletd always calls this RPC with an array of addresses.
  2. zcashd returns the total amount of Zatoshis received by the addresses, but Zebra doesn't because lightwalletd doesn't use that information.

We need to:

  1. Check whether we need to update the getaddressbalance RPC method to fully match zcashd for usecases other than lightwalletd
  2. If so, implement the required changes to support the relevant usecases.

Specification

https://zcash.github.io/rpc/getaddressbalance.html

@github-project-automation github-project-automation bot moved this to New in Zebra Apr 24, 2024
@mpguerra mpguerra added this to the Block Explorer Support milestone Apr 24, 2024
@mpguerra mpguerra moved this from New to Product Backlog in Zebra Apr 24, 2024
@mpguerra mpguerra removed this from the Block Explorer Support milestone Oct 18, 2024
@mpguerra mpguerra changed the title Update getaddressbalance RPC method Update getaddressbalance RPC method for block explorer usage Jan 10, 2025
@mpguerra mpguerra moved this from Product Backlog to Sprint Backlog in Zebra Jan 22, 2025
@mpguerra mpguerra moved this from Sprint Backlog to Product Backlog in Zebra Jan 23, 2025
@mpguerra mpguerra moved this from Product Backlog to Sprint Backlog in Zebra Jan 23, 2025
@arya2 arya2 self-assigned this Feb 12, 2025
@arya2
Copy link
Contributor

arya2 commented Feb 12, 2025

We need a db format upgrade for this one to add the received field.

@mpguerra mpguerra added the A-state Area: State / database changes label Feb 13, 2025
@arya2 arya2 moved this from Sprint Backlog to In progress in Zebra Feb 21, 2025
@arya2 arya2 linked a pull request Feb 24, 2025 that will close this issue
5 tasks
@mpguerra mpguerra linked a pull request Feb 25, 2025 that will close this issue
5 tasks
@pacu pacu moved this from Todo to In Progress in Zebra Block Explorer Support Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-state Area: State / database changes
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants