VS2008: warning C4003 - min/max problem

[escherstair]

The issue is exactly what is described here and here.
It seems that if I compile with VS2008 and <Windows.h> is included before <document.h>, a conflict between min and max macros arises.
The issue happens at lines 1008, 1014, 1015, 1032 and 1033 of <document.h> and can be fixed adding parentheses around the calls to std::numeric_limits<float>::max and std::numeric_limits<float>::min
I mean that line 1008 should be changed from
&& (d < static_cast<double>(std::numeric_limits<uint64_t>::max()))
to
&& (d < static_cast<double>((std::numeric_limits<uint64_t>::max)()))
and so on....

Could you implement this fix, please?

[chwarr]

I'm pretty sure this has been fixed already in 6e38649 (and for the tests in e4c0ecf).

[escherstair]

I see that you're right.
I've been using latest stable release v1.1.0 and so the fix hasn't been included yet.
Do you know if a new stable release will be released soon?
Otherwise I'll download the head of master branch

[chwarr]

I can't give a definitive answer about when the next release will come out: I just contributed the min/max patches. There are some issues open about tagging a release:

• Time for the next release? #1006
• Tag new release #1130

[sonal71]

Found the same issue in reader.h line 1704
if (d > std::numeric_limits::max())

The solution in this thread fixed the issue.

Thank you!

[chwarr]

It looks like a recent commit, 2ea4343, added some more uses of std::numeric_limits::max(). I've created PR #1302 to address these uses as well.