Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate etherscan verify as a githook and add as a merge blocking condition #447

Open
butlerji opened this issue Jul 13, 2022 · 1 comment
Labels
good first issue Good for newcomers protocol protocol related

Comments

@butlerji
Copy link
Contributor

This is an important step to allow Decentralised Contract Deployment, as we have separated deployment from verification, and can be sure what's checked into git is what's deployed on mainnet/testnet.

@BoxedFruits
Copy link
Contributor

BoxedFruits commented Aug 15, 2022

I am interested in picking this up but want to make sure that I am understanding the ticket correctly.

Whenever there is a new deploy of contracts helper.ts should be updated. What we want to add is that if the constants mentioned here are changed because of a new deployement, there should be a githook that blocks merging to the main branch if it is not verified?

There should be a way to verify it programmatically in hardhat: https://youtu.be/gyMwXuJrbJQ?t=31875

@MrMysteryMeat MrMysteryMeat mentioned this issue Dec 6, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers protocol protocol related
Projects
None yet
Development

No branches or pull requests

2 participants