fix(signature): use char_under_cursor in on_char_added handler
#935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`char` from the `on_char_added` handler, which was used before, doesn't represent the character under the cursor in some situations, such as when using an autopairs plugin. Fixes Saghen#909
|
Thank you! |
peter-bread
added a commit
to peter-bread/peter.nvim
that referenced
this pull request
Jan 8, 2025
No longer need hacky approach to get signature help to work. Turns out the issue was to do with autopairs. See Saghen/blink.cmp#935
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charfrom theon_char_addedhandler, which was used before, doesn't represent the character under the cursor in some situations, such as when using an autopairs plugin.Fixes #909