feat: drop source groups in favor of fallback_for #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saghen
force-pushed
the
feat/fallback-sources
branch
3 times, most recently
from
6035b18 to
595148d
Compare
Saghen
force-pushed
the
feat/fallback-sources
branch
from
595148d to
5d0bca3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concept of sources groups was copied from nvim-cmp, but in reality, we want to set sources that act as fallbacks for other sources. In the default config, this would be the buffer source acting as a fallback for the LSP source. This avoids the buffer source from never running when using global snippets that always show
Closes #59