Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: documentation losing syntax highlighting on doc reopen #768

Merged

Conversation

mikavilpas
Copy link
Contributor

@mikavilpas mikavilpas commented Dec 25, 2024

Issue

Providers (completion plugins) can provide a custom implementation for rendering the documentation. Some need to use e.g. Neovim's built-in regex based syntax highlighting. If the documentation window is closed and reopened, the syntax highlighting is lost.

docs.mov

Solution

Allow plugins to redraw the documentation window when the documentation window is reopened.

toggle-fixed.mov

Solves #703

@Saghen
Copy link
Owner

Saghen commented Dec 29, 2024

Perhaps we should clear docs.shown_item on closed instead? We would need to create a .close() on the docs module but we should have that either way

Issue
=====

Providers (completion plugins) can provide a custom implementation for
rendering the documentation. Some need to use e.g. Neovim's built-in
regex based syntax highlighting. If the documentation window is closed
and reopened, the syntax highlighting is lost.

Solution
========

Allow plugins to redraw the documentation window when the documentation
window is reopened.

Solves Saghen#703
@mikavilpas mikavilpas force-pushed the redraw-provider-documentation-on-window-open branch from 7b5676e to 18b5ea2 Compare December 29, 2024 08:39
@mikavilpas
Copy link
Contributor Author

Good idea - I implemented something that seems to work.

@Saghen Saghen merged commit ef59763 into Saghen:main Dec 29, 2024
@Saghen
Copy link
Owner

Saghen commented Dec 29, 2024

Great work as always, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants