Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flickering of completion menu with 2 LSPs #691

Closed
2 tasks done
arztareef opened this issue Dec 21, 2024 · 3 comments
Closed
2 tasks done

Flickering of completion menu with 2 LSPs #691

arztareef opened this issue Dec 21, 2024 · 3 comments
Labels
bug Something isn't working sources Specific source provider or the system as a whole

Comments

@arztareef
Copy link

arztareef commented Dec 21, 2024

Make sure you have done the following

  • I have updated to the latest version of blink.cmp
  • I have read the README

Bug Description

sample specifying the bug:

Screen.Recording.2024-12-21.at.11.10.10.AM.mp4

As the recording suggests, blinking (no pun intended) occurs with the menu.
This only occured to me when I am writing property for a CSS selector with using the LSP (cssls and emmet-language-server)

Relevant configuration

--- Not sure what could be the relevant config for this matter, pasting the one for the menu in here:
{
  completion = {
    list = {
      max_items = 50,
      selection = 'manual',
    },
    menu = {
      max_height = 100,
      scrolloff = 999,
    },
  },
}

neovim version

NVIM v0.11.0-dev-1388+g39781be14b

blink.cmp version: branch, tag, or commit

v0.*

@arztareef arztareef added the bug Something isn't working label Dec 21, 2024
@emnnipal
Copy link

I’m experiencing the same issue as well, but with emmet-language-server.

blink-issue.mov

@arztareef
Copy link
Author

i forgot to mention, i used emmet-language-server as well alongside cssls

@Saghen
Copy link
Owner

Saghen commented Dec 21, 2024

For anyone looking to fix this, we show the menu as soon as any LSP returns a response, with the motivation being to prevent slow LSPs from blocking all the LSPs. We should instead make this configurable since it shouldn't be necessary in most cases. In the future, it would be ideal if we could detect slow LSPs explicitly

@Saghen Saghen added the sources Specific source provider or the system as a whole label Dec 21, 2024
@Saghen Saghen changed the title bug: flickering of completion menu w/ cssls Flickering of completion menu with 2 LSPs Dec 21, 2024
@Saghen Saghen closed this as completed in 86a13ae Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sources Specific source provider or the system as a whole
Projects
None yet
Development

No branches or pull requests

3 participants