Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: completion auto_insert replace incorrect range (#460) #621

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

Goose97
Copy link
Contributor

@Goose97 Goose97 commented Dec 17, 2024

Close #460

This PR fixes the issue by also reset the cursor position when we undo the preview. The undo consists of two parts now:

  • Apply a text edit to restore the buffer content
  • Restore the cursor position (if needed)

@Saghen Saghen merged commit 5926869 into Saghen:main Dec 17, 2024
@Saghen
Copy link
Owner

Saghen commented Dec 17, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completion with list.selection = "auto_insert" doesn't work properly
2 participants