Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation window north of the completion window covers text #194

Closed
chrisgrieser opened this issue Oct 25, 2024 · 2 comments
Closed
Labels
bug Something isn't working windows Module which displays UI

Comments

@chrisgrieser
Copy link
Contributor

chrisgrieser commented Oct 25, 2024

When the documentation window is placed north of the completion window, it covers up the actual text you are currently typing. I assume this is due to an off-by-one error, since placing it one cell further above should fix the issue?

Pasted image 2024-10-25 at 15 59 56@2x

@Saghen Saghen changed the title Bug: documentation window north of the completion window covers text Documentation window north of the completion window covers text Oct 25, 2024
@Saghen Saghen added bug Something isn't working windows Module which displays UI labels Oct 25, 2024
@Saghen
Copy link
Owner

Saghen commented Oct 30, 2024

I'm unable to reproduce on v0.5.0 but lmk if you're still able to reproduce it, ideally with steps

@chrisgrieser
Copy link
Contributor Author

chrisgrieser commented Oct 30, 2024

Well, it still happens with 0.5.0. It happens with the default config, and occurs any time when the autocompletion suggestions are south and the documentation window is shown north.

Reproduction steps for the conditions to occur:

  1. set scrolloff to 0 and resize the terminal window so it is smaller to simply things.
  2. go to a new line
  3. press <space> until the cursor is in the middle of the screen.
  4. Use <C-e> / <C-y> to position the viewport in a way that the cursor is in the middle bottom of the viewport.
  5. type anything gives suggestions
  6. <C-space> to open the suggestions. The suggestions must show up south of the cursor.
  7. <C-space> again to show the documentation window. If the cursor is positioned correctly in the previous steps, the documentation window should up north.
  8. Issue occurs.

Pasted image 2024-10-30 at 19 25 48@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows Module which displays UI
Projects
None yet
Development

No branches or pull requests

2 participants