fix(cmdline): preserve range prefix when applying text edits #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
yoursvivek
reviewed
Feb 5, 2025
lua/blink/cmp/lib/text_edits.lua
Outdated
| if mode == 'cmdline' then | ||
| local line = context.get_line() | ||
| -- Detect range markers '<,'>' or numeric ranges '3,5' | ||
| local prefix = line:match("^%s*['<,>%d]+%s*") |
There was a problem hiding this comment.
following is more precise
Suggested change
| local prefix = line:match("^%s*['<,>%d]+%s*") | |
| local prefix = line:match("^%s*'<%s*,%s*'>%s*") or line:match("^%s*%d%s*,%s*%d%s*") |
There was a problem hiding this comment.
Tthanks, I moved the regex matching elsewhere as suggested by @Saghen.
|
Thanks for the PR! This logic should be implemented in the cmdline source directly, rather than in the text edits library |
I moved it accordingly, hope this is satisfactory. |
|
Thank you! I've rebased and merged on main since Github wasn't letting me push to this branch for some reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1092 by doing the following: