Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path completion in Windows using backward slash #1152

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

marovira
Copy link
Contributor

@marovira marovira commented Feb 4, 2025

Fixes #1151 by doing the following:

  1. Ensure that \ is allowed as a trigger character.
  2. Fix the path regex to handle Windows correctly.

The implementation for the path regex was taken directly from async_path. I've already tested this on Windows and can confirm that it correctly handles both C:/ and C:\ paths.

@Saghen Saghen merged commit 575784f into Saghen:main Feb 4, 2025
3 checks passed
@Saghen
Copy link
Owner

Saghen commented Feb 4, 2025

Thanks!

@marovira marovira deleted the windows-path branch February 4, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for backward slash \ for path completion in Windows
2 participants