Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences to hashes #194

Closed
TheAlgorythm opened this issue Jul 24, 2021 · 6 comments
Closed

Differences to hashes #194

TheAlgorythm opened this issue Jul 24, 2021 · 6 comments

Comments

@TheAlgorythm
Copy link

Please clarify in the README's why this crate is recommended for passwords.
This surprises me especially as this crate, as far as I know, doesn't support pepper.
Therefore, I am interested if there is a security reason to not use something like Blake2b or if it makes it only easier to do everything right.

@tarcieri
Copy link
Member

The toplevel README links to the OWASP Password Storage Cheat Sheet, which should answer all of your questions. Namely it covers:

We previously considered maintaining more extensive documentation for this (#48) but decided the OWASP guide already covered all of this information. However, perhaps we could feature it more prominently.

@TheAlgorythm
Copy link
Author

The only downside of hashes I see is that it doesn't support Argon2.
But then I don't see an architectural benefit in using this as I can't use PasswordHash with verify_password since the hash needs to be HMACed. So with a pepper it's even a bit more complicated. Maybe it would be possible to implement a pepper with MAC here?

@tarcieri
Copy link
Member

Adding support for pepper to the password-hash crate is an interesting suggestion. Maybe make a feature request for it on https://github.com/RustCrypto/traits ?

@TheAlgorythm
Copy link
Author

Yeah, I can do that. But I am not sure wether it should be more a separate trait or an extension to the current system?

@tarcieri
Copy link
Member

It could be part of the existing traits

@tarcieri
Copy link
Member

tarcieri commented Mar 5, 2023

Discussion moved to RustCrypto/traits#694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants