pos_payment_change : payment_date

[jguenat]

Hello,

In module pos_payment_change, the field payment_date (Datetime) is set as shown bellow when changing a payment.

pos/pos_payment_change/wizards/pos_payment_change_wizard.py

Line 93 in df170b5

"payment_date": fields.Date.context_today(self),

I have some issues with this :

• the field payment_date is of type Datetime but is assigned a Date -> New payment will be at a strange hour (01:00 in the morning).
• If you change a payment a few days after the order, e.g. when closing the pos session, then the new payment_date will be the day you do the correction which does not reflect reality.

I think it would be best to use the payment_date of the original payment or better to let the user choose the date and time in the wizard (with a default at the order creation date/time).

Do you know why it was done that way originally?

Depending on feedback I could propose an improvement.

Thank you

[legalsylvain]

I think it would be best to use the payment_date of the original payment or better to let the user choose the date and time in the wizard (with a default at the order creation date/time).

Totally agree. @quentinDupont what do you think ?