Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMUI package vulnerability service improvements #14138

Open
Nigusu-Allehu opened this issue Feb 25, 2025 · 0 comments
Open

PMUI package vulnerability service improvements #14138

Nigusu-Allehu opened this issue Feb 25, 2025 · 0 comments
Labels
Area:NuGetAudit Functionality:VisualStudioUI Package Manager UI et al Priority:2 Issues for the current backlog. Product:VS.Client TechDebt Technical debt Type:Bug

Comments

@Nigusu-Allehu
Copy link
Contributor

Nigusu-Allehu commented Feb 25, 2025

  • The package vulnerability service is currently called on Vs shutdown cancellation token. We should use a cancellation token that cancels when the refresh button is clicked
  • The service only refreshes when the refresh button is clicked. Consider the situation where the PMUI has been open for a long time and the refresh button was never clicked. Maybe we should refresh every time the vulnerability cache files expire and are reloaded.
  • PackageManagerControl.xaml.cs has an async call to GetVulnerabilityInfoAsync per package. Reduce the unnecessary async calls by adding a method to the package vulnerability service that takes in a collection of packages and makes one async call to get the vulnerability data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:NuGetAudit Functionality:VisualStudioUI Package Manager UI et al Priority:2 Issues for the current backlog. Product:VS.Client TechDebt Technical debt Type:Bug
Projects
None yet
Development

No branches or pull requests

2 participants