Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fastx CLI] Improve demo wallet's UX and add option to choose between pretty print or json output #403

Closed
patrickkuo opened this issue Feb 9, 2022 · 3 comments · Fixed by #536
Closed

[fastx CLI] Improve demo wallet's UX and add option to choose between pretty print or json output #403

patrickkuo opened this issue Feb 9, 2022 · 3 comments · Fixed by #536
Assignees
@patrickkuo

Comments

@patrickkuo
Copy link
Contributor

patrickkuo commented Feb 9, 2022 •
edited
Loading

the output for the wallet is quite raw and can be quite difficult to read, we will need to make it look nicer for the shell user.

We might want to keep the raw output for the non-shell user (running with the no-shell flag), to allow the output to be consumed by downstream programs (shell script/ python?).

We can also use prettytable to create a tabular output, an example can be found in @oxade 's branch 69375a0
@patrickkuo patrickkuo mentioned this issue Feb 9, 2022
Merged
@oxade
Copy link
Contributor

oxade commented Feb 9, 2022

I can take this

@oxade
Copy link
Contributor

oxade commented Feb 9, 2022

Actually maybe a better task for someone new. Plus it's not critical right now.

@patrickkuo patrickkuo changed the title [fastx CLI] Improve demo wallet's UX and make the output prettier [fastx CLI] Improve demo wallet's UX and add option to choose between pretty print or json output Feb 11, 2022
@sblackshear sblackshear added this to the Private SDK Release milestone Feb 13, 2022
@patrickkuo
Copy link
Contributor Author

I will take this one :)

@patrickkuo patrickkuo self-assigned this Feb 15, 2022
@patrickkuo patrickkuo linked a pull request Feb 23, 2022 that will close this issue
[fastx CLI] Improve demo wallet's UX and add option to choose between pretty print or json output #536
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@patrickkuo patrickkuo

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@patrickkuo @sblackshear @oxade