Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

The "selectedView" is not working in the REPL #456

Closed
Krumelur opened this issue Jun 25, 2018 · 7 comments
Closed

The "selectedView" is not working in the REPL #456

Krumelur opened this issue Jun 25, 2018 · 7 comments
Labels
Area: View Inspection macOS Regression

Comments

@Krumelur
Copy link

Steps to Reproduce

On the Mac:

  1. Start an iOS app
  2. Start inspector via VS' crosshair icon
  3. Switch to the UI tree view
  4. Select a view
  5. Switch back to REPL
  6. Type selectedView

Expected Behavior

Info about the selected view should be shown.

Actual Behavior

Error: The name 'selectedView' does not exist in the current context

Environment

macOS

Xamarin Inspector

Detail Value
Version 1.4.0
Git Branch master
Git Hash b3f92f9
VSTS Definition Workbooks & Inspector (Mac)

System Info

Component Value
macOS Version 10.13.5 (Build 17F77) (64-bit)
CPU Cores 8 / 8
Physical Memory 24 GB

System-Installed Software

Component Version
Mono 5.10.1.57
Xamarin Mac 4.4.1.193
Xamarin iOS 11.12.0.4
Xamarin Android 8.3.3-2
Visual Studio 7.5.2.40 (705020040)

Log File

Xamarin Inspector 2018-06-25.log
@bojanrajkovic
Copy link
Contributor

I wonder if this didn't regress when we plugged the new property editor in.

@sandyarmstrong
Copy link
Member

I have a vague recollection that this is working in Windows but broken in Mac.

@bojanrajkovic
Copy link
Contributor

Could be, I only tested on Mac this morning.

@sandyarmstrong
Copy link
Member

This definitely works for WPF inspection on Windows. I believe it works for iOS inspection on Windows as well, but cannot test that just yet. So I believe this is a Mac client regression.

@sandyarmstrong
Copy link
Member

Confirmed it works fine with iOS/Windows.

@sandyarmstrong
Copy link
Member

Regressed in #124.

sandyarmstrong added a commit to sandyarmstrong/workbooks that referenced this issue Jul 2, 2018
@sandyarmstrong
Client: Set selectedView in shared code
1f4af56 
This was accidentally deleted from the Mac client in 1.4.0.

Force callers to go through `SetSelectedView` method to make the flow
safer and avoid situations where `SetSelectedView` got called an extra
time.

Fixes: microsoft#456
sandyarmstrong added a commit to sandyarmstrong/workbooks that referenced this issue Jul 2, 2018
@sandyarmstrong
Client: Set selectedView in shared code
b46f518 
This was accidentally deleted from the Mac client in 1.4.0.

Force callers to go through `SetSelectedView` method to make the flow
safer and avoid situations where `SetSelectedView` got called an extra
time.

Fixes: microsoft#456
@sandyarmstrong sandyarmstrong mentioned this issue Jul 2, 2018
Merged
@abock abock closed this as completed in #468 Jul 3, 2018
lewing pushed a commit to lewing/workbooks that referenced this issue Jul 3, 2018
@sandyarmstrong @lewing
Client: Set selectedView in shared code
aa5ab17 
This was accidentally deleted from the Mac client in 1.4.0.

Force callers to go through `SetSelectedView` method to make the flow
safer and avoid situations where `SetSelectedView` got called an extra
time.

Fixes: microsoft#456
@sandyarmstrong
Copy link
Member

This is fixed in the 1.4.2 Inspector client, which will be bundled in the next preview release of Visual Studio for Mac 7.6.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Area: View Inspection macOS Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bojanrajkovic @sandyarmstrong @Krumelur