Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: e2e gate #13696

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

feat: e2e gate #13696

wants to merge 45 commits into from

Conversation

jake-perkins
Copy link
Contributor

@jake-perkins jake-perkins commented Feb 24, 2025

Description

Introduces a new e2e gate that can be used to control whether PRs are mergeable.

Related issues

Fixes:
#11747

Manual testing steps

CICD Testing

UC1: Has Anti Label ( SUCCESSFUL/EXPECTED RESULT )
Expected : Should be mergeable

UC2: Has Smoke Label but fails pipeline ( SUCCESSFUL/EXPECTED RESULT )
Expected : Should NOT be mergeable

UC3: Has Smoke label but e2e fails ( SUCCESSFUL/EXPECTED RESULT )
Expected Should NOT be mergeable

UC4 : Has Smoke label with e2e passes ( SUCCESSFUL )
Expected Should be mergeable

UC5 : No bitrise test results found for recent commits
https://github.com/MetaMask/metamask-mobile/actions/runs/13690456059/job/38282658781?pr=13696

UC6 : pending bitrise run
https://github.com/MetaMask/metamask-mobile/actions/runs/13690499626/job/38282774034?pr=13696
it runs before the test is done

Screenshots/Recordings

N/A - CICD Only

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jake-perkins jake-perkins requested a review from a team as a code owner February 24, 2025 18:42
@metamaskbot metamaskbot added the team-dev-ops DevOps team label Feb 24, 2025
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jake-perkins jake-perkins changed the title e2e feat: e2e gate Feb 24, 2025
@jake-perkins jake-perkins added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 24, 2025
Copy link
Contributor

github-actions bot commented Feb 24, 2025

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 6200111
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b8b6a97c-8a9a-4381-b387-8d57dfd455e5

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jake-perkins jake-perkins added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 24, 2025
@jake-perkins jake-perkins added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 25, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 635aa41
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6c1841da-06ef-4130-9b24-dce118a28055

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jake-perkins jake-perkins added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 25, 2025
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 1a9381e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/599103ca-ed39-441e-9993-0e75e74a7b09

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jake-perkins jake-perkins added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 25, 2025
Copy link
Contributor

github-actions bot commented Feb 25, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 51dc848
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d72e2380-a315-45cc-8074-504c504e5f9c

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@jake-perkins jake-perkins added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.85%. Comparing base (d1d22d7) to head (f370111).
Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13696      +/-   ##
==========================================
+ Coverage   63.42%   63.85%   +0.42%     
==========================================
  Files        2093     2136      +43     
  Lines       45277    45642     +365     
  Branches     6234     6313      +79     
==========================================
+ Hits        28717    29143     +426     
+ Misses      14676    14605      -71     
- Partials     1884     1894      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jake-perkins jake-perkins added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: aceb0e3
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0b3217ad-4d42-40ad-a739-f4f36174aa94

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link

sonarqubecloud bot commented Mar 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise team-dev-ops DevOps team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants