Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refractor] copy-pasted codes in the "driver.py" #26

Open
Shaoting-Feng opened this issue Nov 13, 2024 · 0 comments
Open

[Refractor] copy-pasted codes in the "driver.py" #26

Shaoting-Feng opened this issue Nov 13, 2024 · 0 comments
Assignees

Comments

@Shaoting-Feng
Copy link
Contributor

Describe the problem

There are multiple copy-pasted codes in the "driver.py". We need to refactor it. Some example:

  • execute_one_request and execute_one_request_with_output
  • execute_all and execute_all_with_output
  • execute_openai_request and execute_openai_request_with_output
  • run_experiment and run_multi_turn_experiment

In these similar functions, the difference may only be one additional return value, so it is a good idea to delete the copy-pasted codes and just use one function in the above pairs.

How to test

For the first functions in these pairs, you can use test_lmcache_local_cpu to test. For the second functions in these pairs, you can use test_multi_turn to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants