Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements, updated libraries and image features #118

Merged
merged 13 commits into from
Sep 29, 2020

Conversation

Emulator000
Copy link
Contributor

@Emulator000 Emulator000 commented Sep 27, 2020

In this PR I updated all libraries, applied various code improvements, fixed tests in case of non enabled chrono feature and done some enrichments on the embed_image feature, now supports buffers.

I also added an useful function for the Document struct called get_object_page(), this function will return the Page ObjectId if found, useful for inserting certain element of another dependent ObjectId and another useful remove_object() function that is able to correctly remove an object from the page and the reference.

I also formatted the code with cargo fmt in order to be compliant to all Rust 2018 rules.

@J-F-Liu please wait before merging this, I'll to check if the embed_image is working properly because I think that is a little buggy. Maybe is not well tested as is not a default feature :-)

@Emulator000 Emulator000 force-pushed the improvements branch 2 times, most recently from 82d9ce6 to b27588b Compare September 27, 2020 11:16
@Emulator000
Copy link
Contributor Author

Emulator000 commented Sep 27, 2020

@J-F-Liu you can now review and merge now!

I've fixed a failing test on the CI too, everything should be ok :)

Let me know when you will cargo publish it in order to immediately use it on my project, thank you!

@J-F-Liu
Copy link
Owner

J-F-Liu commented Sep 29, 2020

Package version should be 0.26.0, or leave it unchanged, I'll bump the version number separately and publish.

@Emulator000
Copy link
Contributor Author

@J-F-Liu done, changed to 0.26 :-)

Please let me know when you'll publish it, thanks!

@J-F-Liu J-F-Liu merged commit 56e6bf3 into J-F-Liu:master Sep 29, 2020
@Emulator000 Emulator000 deleted the improvements branch September 29, 2020 09:33
@J-F-Liu
Copy link
Owner

J-F-Liu commented Sep 29, 2020

Published just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants