-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements, updated libraries and image features #118
Conversation
…result merged PDF
…of non "chrono" feature and enrichments on the "embed_image" feature
f2a3dc9
to
a252287
Compare
82d9ce6
to
b27588b
Compare
b27588b
to
00ae4cb
Compare
…lculation system for image colors
@J-F-Liu you can now review and merge now! I've fixed a failing test on the CI too, everything should be ok :) Let me know when you will |
Package version should be 0.26.0, or leave it unchanged, I'll bump the version number separately and publish. |
@J-F-Liu done, changed to 0.26 :-) Please let me know when you'll publish it, thanks! |
Published just now. |
In this PR I updated all libraries, applied various code improvements, fixed tests in case of non enabled
chrono
feature and done some enrichments on theembed_image
feature, now supports buffers.I also added an useful function for the
Document
struct calledget_object_page()
, this function will return the PageObjectId
if found, useful for inserting certain element of another dependentObjectId
and another usefulremove_object()
function that is able to correctly remove an object from the page and the reference.I also formatted the code with
cargo fmt
in order to be compliant to all Rust 2018 rules.@J-F-Liu please wait before merging this, I'll to check if the
embed_image
is working properly because I think that is a little buggy. Maybe is not well tested as is not a default feature :-)