New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[viewer] "Fetching report from GitHub..." toast is never dismissed #13202

Closed

brendankenny opened this issue Oct 12, 2021 · 1 comment · Fixed by #13204

Assignees

Labels

bug needs-priority viewer

Member

brendankenny commented Oct 12, 2021

need a report that doesn't get the "older version of Lighthouse" warning, like this a11y one: https://googlechrome.github.io/lighthouse/viewer/?gist=8c8747c376d7b592427ee5da8c954f19

I assume this is from a change in #13115 or #13116

github-actions bot assigned adamraine

brendankenny added viewer bug labels

devtools-bot added the needs-priority label

connorjclark assigned connorjclark and unassigned adamraine

Collaborator

connorjclark commented Oct 12, 2021 •

edited

Loading

two things at issue here:

lh-logger uses show instead of the new lh-show
viewer doesn't have the styles for #lh-log until the report is rendered...

This was referenced Oct 12, 2021

report: add lh- prefix to remaining show class #13203

Merged

report: move logger styles into js #13204

Merged

devtools-bot closed this as completed in #13204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment