From e29266ab70b806dad2d3e142966be792de993497 Mon Sep 17 00:00:00 2001 From: Connor Clark Date: Tue, 1 Aug 2023 16:57:38 -0700 Subject: [PATCH] oopsie --- core/gather/gatherers/full-page-screenshot.js | 2 +- core/test/gather/gatherers/full-page-screenshot-test.js | 3 --- core/test/scripts/run-mocha-tests.js | 3 +++ 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/gather/gatherers/full-page-screenshot.js b/core/gather/gatherers/full-page-screenshot.js index 89d9f7d65973..b106772aae49 100644 --- a/core/gather/gatherers/full-page-screenshot.js +++ b/core/gather/gatherers/full-page-screenshot.js @@ -13,7 +13,7 @@ import {waitForNetworkIdle} from '../driver/wait-for-condition.js'; // JPEG quality setting // Exploration and examples of reports using different quality settings: https://docs.google.com/document/d/1ZSffucIca9XDW2eEwfoevrk-OTl7WQFeMf0CgeJAA8M/edit# // Note: this analysis was done for JPEG, but now we use WEBP. -const FULL_PAGE_SCREENSHOT_QUALITY = process.env.LH_FPS_TEST ? 30 : 100; +const FULL_PAGE_SCREENSHOT_QUALITY = process.env.LH_FPS_TEST ? 100 : 30; // https://developers.google.com/speed/webp/faq#what_is_the_maximum_size_a_webp_image_can_be const MAX_WEBP_SIZE = 16383; diff --git a/core/test/gather/gatherers/full-page-screenshot-test.js b/core/test/gather/gatherers/full-page-screenshot-test.js index 6d608fb08b72..76f5dc290e49 100644 --- a/core/test/gather/gatherers/full-page-screenshot-test.js +++ b/core/test/gather/gatherers/full-page-screenshot-test.js @@ -232,9 +232,6 @@ describe('FullPageScreenshot gatherer', () => { server = new Server(port); await server.listen(port, '127.0.0.1'); serverBaseUrl = `http://localhost:${server.getPort()}`; - - // Tell gatherer to use 100 quality. - process.env.LH_FPS_TEST = '1'; }); after(async () => { diff --git a/core/test/scripts/run-mocha-tests.js b/core/test/scripts/run-mocha-tests.js index 1c99b5de2509..fc5bd253ceeb 100644 --- a/core/test/scripts/run-mocha-tests.js +++ b/core/test/scripts/run-mocha-tests.js @@ -22,6 +22,9 @@ import glob from 'glob'; import {LH_ROOT} from '../../../shared/root.js'; import {mochaGlobalSetup, mochaGlobalTeardown} from '../test-env/mocha-setup.js'; +// Tell gatherer to use 100 quality for FPS tests. +process.env.LH_FPS_TEST = '1'; + const failedTestsDir = `${LH_ROOT}/.tmp/failing-tests`; if (!isMainThread && parentPort) {