#1362 [Core] fix: require category class in mod #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-eoxia
requested changes
Jul 7, 2023
core/modules/modDoliSMQ.class.php
Outdated
| @@ -591,6 +591,8 @@ public function init($options = ''): int | |||
| addDocumentModel('controldocument_odt', 'controldocument', 'ODT templates', 'DOLISMQ_CONTROLDOCUMENT_ADDON_ODT_PATH'); | |||
|
|
|||
| if (!empty($conf->global->DOLISMQ_SHEET_TAGS_SET) && empty($conf->global->DOLISMQ_SHEET_DEFAULT_TAG)) { | |||
| include_once DOL_DOCUMENT_ROOT . '/categories/class/categorie.class.php'; | |||
There was a problem hiding this comment.
Require_once est mieux
class/answer.class.php
Outdated
| $this->ref = $refAnswerMod->getNextValue($this); | ||
| $this->position = $this->getMaxPosition() + 1; | ||
| $this->status = $this->status ?: self::STATUS_VALIDATED; | ||
| $refAnswerModName = empty($conf->global->DOLISMQ_ANSWER_ADDON) ? 'mod_answer_standard' : $conf->global->DOLISMQ_ANSWER_ADDON; |
There was a problem hiding this comment.
Rajouter également le check sur le require de la class modAnswer ca améliorera si jamais on change le modèles de réf
There was a problem hiding this comment.
voir dolisirh fichier projet
evarisk-theo
force-pushed
the
fix_missing_require_categorie_class
branch
from
130a7b8 to
f3c1ce0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.