Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Remove template on sls remove #141

Closed
LarsPede opened this issue Jan 4, 2024 · 2 comments · Fixed by #147
Closed

Feature request: Remove template on sls remove #141

LarsPede opened this issue Jan 4, 2024 · 2 comments · Fixed by #147

Comments

@LarsPede
Copy link

LarsPede commented Jan 4, 2024

Hi @Enase

Absolutely amazing plugin - makes all this templating so much more simple to handle.
I think this might be a feature request? or at least a discussion in terms of how one might do a workaround.

The current behaviour:
sls deploy deploys the template and can send emails based on it.
sls remove does not remove the template in the cleanup step.

The feature request:
sls deploy deploys the template and can send emails based on it.
sls remove does removes the template in the cleanup step.

Version
serverless: 3.32.2
@haftahave/serverless-ses-template: 5.0.2
ESM/commonJS: commonJS

@Enase
Copy link
Owner

Enase commented Jan 4, 2024

@LarsPede Good idea, I will definitely add it next version. Fell free to share any other ideas if you have it. Thanks for your feedback!

@Enase
Copy link
Owner

Enase commented Jan 10, 2024

Hi @LarsPede New versions are published, thanks for your effort and feel free to use:
ESM: 6.1.0
CommonJS: 5.1.0
Pls report issues if any.

@Enase Enase closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants