Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] SuperSuit Support #524

Closed
1 task done
jkterry1 opened this issue Jul 29, 2021 · 0 comments
Closed
1 task done

[Feature Request] SuperSuit Support #524

jkterry1 opened this issue Jul 29, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@jkterry1
Copy link
Contributor

jkterry1 commented Jul 29, 2021

🚀 Feature

Use SuperSuit as the basis for wrappers inside of SB3

Motivation

SuperSuit provides wrappers for Gym environments that are fully featured and much cleaner than custom solutions or the built in Gym wrappers. I'm going to be deprecating the built in wrappers in Gym in favor of SuperSuit in the near future. I'll still keep the built in ones and they'll continue to work for the foreseeable future, they'll just throw depreciation warnings. SuperSuit has versioning for proper reproducibility, good code factoring a bunch of other important features. Specific features relevant to the switch in SB3 are the lambda and vectorization wrappers.

If you are interested in doing this, I would specifically request that you don't switch to using SuperSuit's vector environment conversions for at least a few more months until the dust settles surrounding documentation of, and potential revision to, Gym's vector environment API.

Also using SuperSuit wrappers in rl baselines3 would make my research meaningfully easier, but that's a tangentially related problem.

Alternatives

Doing nothing would only result in depreciation warnings. I don't intend to break anything of yours.

### Checklist

  • I have checked that there is no similar issue in the repo (required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant